Page 1 of 1

I have control over the github repo

Posted: Thu Apr 30, 2020 10:16 pm
by kgschlosser
We now have the ability to continue with development FINALLY!!
YAY!!!!

What I need is some people that are familiar with GitHub to some extent and I also need people that are willing to learn how to compile EG so they can test code changes I make and see if there are any errors. I have a couple of PR's I have just submitted and another couple I have already merged. I want to get 0.5 fully released.

I also want a list of all of the bugs that are outstanding. These are the bugs I know about and their status

Error when opening the option dialog. FIXED
Error when checking to see if the user account that is running EG is a domain admin and a local admin. FIXED (needs to be tested)
Error when using a "non standard" locale. FIXED (needs testing)
Error when getting the thousands separator in SpinNumCtrl. FIXED (needs testing)
Broadcaster error when opening send dialog. FIXED
ATIRemoteWonder II traceback when using the mouse on the remote. FIXED
OK button being grayed out in config dialog when adding a new plugin and there are no configuration changes that need to be made. IN PROGRESS


For anyone that wants to help out here is a link to a test version of EG. This test version has only the locale changes added to it. the options dialog will still error in this version

If you had been getting an error for locale or getting an error related to SpinNumCtrl this should fix those issues. These errors have to deal with the Windows locale settings. so if you want to mess around with it you will want to change the language and locale in windows and then run EG and see if you can get it to throw an error.
https://ci.appveyor.com/api/buildjobs/c ... _Setup.exe

Let me know what you come up with.


Here is a test version that has a fix for checking to see if a user has administrative privileges
https://ci.appveyor.com/api/buildjobs/q ... _Setup.exe

Re: I have control over the github repo

Posted: Fri May 01, 2020 9:09 am
by Sem;colon
Yay! That's really good news! :)
kgschlosser wrote:
Thu Apr 30, 2020 10:16 pm
OK button being grayed out in config dialog when adding a new plugin and there are no configuration changes that need to be made. IN PROGRESS
I have an easy fix for that one - just remove that feature again and don't gray out the OK button. For the most plugins I've seen the default settings are just fine and for the others.. well.. you'll never be able to fix stupid :wink:

Re: I have control over the github repo

Posted: Fri May 01, 2020 2:34 pm
by dequi
Awesome, but I see that CarsonF is no longer in the "People" list, nor is Eventghost in his organisation list. Does he still have access? Just to know if we could still reach out to him in case you go AWOL as well. I knew topic2k has full access but he is apparently on a sabbatical, and I thought Pako2 had access too, but I'm not sure.

Re: I have control over the github repo

Posted: Fri May 01, 2020 5:53 pm
by kgschlosser
yes he is a "hidden" owner

Re: I have control over the github repo

Posted: Fri May 01, 2020 5:58 pm
by kgschlosser
@sem;colon.

Yes I agree that stupid cannot be fixed.. LOL
I know I have to go and locate the original PR and see if i am able to revert it. and if not I will "undo" it in a new PR.
I wanted to list the bugs so I know what I have to get fixed and tested before I release 0.5 I would like to not do another release candidate. I have merged the PR's i made that have been tested and do work.

@sem;colon You had found a problem in the webserver plugin. what was it do you remember off the top of your head?
I also do know there is an issue with certificates and we had started working on that problem. I am going to revisit that one as well.

Re: I have control over the github repo

Posted: Fri May 01, 2020 8:26 pm
by Sem;colon
Hi Kevin,

Yay! Very good, so looking forward to EG 0.5 final! :D :D :D

Actually I'm using certificates with the webserver plugin and never had an issue with it.. but I'm also not using websockets, maybe that's why :|

For the problem I found, the solution was to configure a timeout for the connection, which is not the case at the moment. This, in some circumstances, can create a dead-lock, and that's what I was getting every now and then. Since adding the timeout over a year ago, the webserver runs rock-solid 24/7 and it didn't cause any other issues for me (again, I'm not using websockets, so I didn't test that)
Let me upload my modification for you..
Ok, it's attached, but you may want to run a diff before merging, as I'm unsure if there were other changes to the repo recently

Re: I have control over the github repo

Posted: Fri May 01, 2020 10:26 pm
by kgschlosser
I should have stated the certificate problems were with requests and not with the webserver plugin.. That's my bad.

Re: I have control over the github repo

Posted: Sat May 02, 2020 7:38 am
by kgschlosser
I updated the first post.

Re: I have control over the github repo

Posted: Sun May 03, 2020 3:10 am
by jachin99
I'll help out, I just need to pointed in a direction, I.E. Learn to compile, and test changes, or learn GitHub. I think compiling locally might be a good start. I think you have an old post around here somewhere with instructions for that but I'm not sure if its current.

Re: I have control over the github repo

Posted: Sun May 03, 2020 7:01 am
by kgschlosser
@jachin99
I provided links to already compiled test versions of EG on the first post.


As an update. I have a working plugin repository. I have to add the program to the server and run some more tests on it. But it is coming along nicely. I wrote it so that we have the ability to have more then the 4 plugin groups. This is going to be controlled by the server. I still have to build an administrative control to it yet for adding new groups and also adding plugins. I do not want the plugin repo to be a "free for all" I would be guilty of doing this. I want to make sure that plugins that have been added are not untested bug fixes for plugins. A bug fix should be tested out by the users in the support for the plugin and then when it is known as working the plugin can then be sent over to a "Plugin Repository Administrator" and they will add the plugin. This is also going to allow us to put together a game plan for what needs to be in a plugin, the coding style of the plugin those kinds of things. We are going to need to put together a brainstorming group for this. If there are any plugin developers that want to have some input shoot me a PM.

I am going to be creating a plugin developers forum thread so we will be able to have conversations about changes in EG. In order to get EG up to date with Python we are going to have to make some changes to how things are done in EG. As much as I am not one to mess about with API there may be some changes that need to be made in that department.

I am going to get the plugin repository up and running first as I feel this is going to be the best way to be able to deliver updated plugins to the users when we do the Python update. I still have to write the code for checking for an update of a plugin when EG starts. there will also have to be a meta tag added for supported EG versions. I also wanted to add monitoring of errors produced by a plugin so that if an error occurs screen shots, logs and all the rest of the goodies needed to help isolate the issue can get collected and the user will be prompted if they want to submit the captured data to the plugin author so they can fix the problem.

I wrote the server side code for the plugin repository an really cool way the url's to obtain any information are dynamically created and are allowed to only be used a single time. so each request is actually 2 requests the first gets a token and the second uses the token in the URL (not as a parameter).

Here is an example of the server logging

Code: Select all

192.168.***.*** - - [03/May/2020 00:25:15] "GET /get_access_token HTTP/1.1" 200 -
192.168.***.*** - - [03/May/2020 00:25:15] "GET /BB0CD316BBE4BA3BE1D0DE8AE0909E/get_plugin_icon?plugin_name=CM11A HTTP/1.1" 200 -
192.168.***.*** - - [03/May/2020 00:25:15] "GET /get_access_token HTTP/1.1" 200 -
192.168.***.*** - - [03/May/2020 00:25:15] "GET /BE7A9378F6E4955A42CDF6B8A49CD4/get_plugin_icon?plugin_name=JVC+HD-1+Projector HTTP/1.1" 200 -
So there is no direct access to any of the plugins. Not even the filenames are known. because the url's are dynamic they cannot be scraped at all.

Re: I have control over the github repo

Posted: Wed Jul 08, 2020 2:17 am
by mattl0
kgschlosser wrote:
Thu Apr 30, 2020 10:16 pm
We now have the ability to continue with development FINALLY!!
YAY!!!!

What I need is some people that are familiar with GitHub to some extent and I also need people that are willing to learn how to compile EG so they can test code changes I make and see if there are any errors. I have a couple of PR's I have just submitted and another couple I have already merged. I want to get 0.5 fully released.

I also want a list of all of the bugs that are outstanding. These are the bugs I know about and their status

Error when opening the option dialog. FIXED
Error when checking to see if the user account that is running EG is a domain admin and a local admin. FIXED (needs to be tested)
Error when using a "non standard" locale. FIXED (needs testing)
Error when getting the thousands separator in SpinNumCtrl. FIXED (needs testing)
Broadcaster error when opening send dialog. FIXED
ATIRemoteWonder II traceback when using the mouse on the remote. FIXED
OK button being grayed out in config dialog when adding a new plugin and there are no configuration changes that need to be made. IN PROGRESS


For anyone that wants to help out here is a link to a test version of EG. This test version has only the locale changes added to it. the options dialog will still error in this version

If you had been getting an error for locale or getting an error related to SpinNumCtrl this should fix those issues. These errors have to deal with the Windows locale settings. so if you want to mess around with it you will want to change the language and locale in windows and then run EG and see if you can get it to throw an error.
https://ci.appveyor.com/api/buildjobs/c ... _Setup.exe

Let me know what you come up with.


Here is a test version that has a fix for checking to see if a user has administrative privileges
https://ci.appveyor.com/api/buildjobs/q ... _Setup.exe
I might come back to install eventghost this summer ! That’s is very noce news !!! Good work

Re: I have control over the github repo

Posted: Wed Jul 08, 2020 5:41 pm
by kgschlosser
@mattl0

That's GREAT!

Let me know if you need a hand with setting things up. I am more then happy to help, If I am not able to I am sure that someone else here on the forum would chime in and lend a hand.